Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres v2: Add support for DeleteWithPrefix #3307

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Postgres v2: Add support for DeleteWithPrefix #3307

wants to merge 6 commits into from

Conversation

ItalyPaleAle
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle commented Jan 6, 2024 •
edited
Loading

Related to #3262

Adds DeleteWithPrefix to the PostgreSQL state store v2.

Notes:

  1. This cannot work with CockroachDB, because CockroachDB does not offer sufficient support for UDFs which are needed to implement this. We will investigate how to add support for CockroachDB later. For now, the component can be instantiated without support for DeleteWithPrefix, so it can be used with CockroachDB
  2. Because of lack of CockroachDB support, this has not been implemented in v1, due to the fact that the components for v1 are more "intertwined". Will be done in a separate PR.
  3. Added conformance tests for YugabyteDB
    • Note that using YugabyteDB requires installing the "crypto" extension. See: https://yugabytedb.tips/?p=2178 We should investigate if we can have Dapr do that automatically.

@ItalyPaleAle ItalyPaleAle requested review from a team as code owners January 6, 2024 00:52
@ItalyPaleAle
WIP: YugabyteDB support
9c415f2 
Signed-off-by: ItalyPaleAle <[email protected]>
@ItalyPaleAle ItalyPaleAle marked this pull request as draft January 6, 2024 01:01
@ItalyPaleAle
Copy link
Contributor Author

Moving to draft to investigate how we can add support for YugabyteDB and CockroachDB.

CockroachDB 23 has some support for UDFs and should be usable.

However, neither YugabyteDB nor CockroachDB support the trim_array function, which we would like to use.

My attempt at defining another UDF "equivalent" to trim_array in CockroachDB failed, as CockroachDB cannot have a UDF invoke another UDF.

@berndverst
Copy link
Member

Enabling conformance tests for Yugabyte really should be a separate PR

@ItalyPaleAle
Copy link
Contributor Author

Enabling conformance tests for Yugabyte really should be a separate PR

Agree. I'll leave it here for now so I can test that the feature works with Yugabyte too, but I'll move it out before marking the PR as ready for review.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 7, 2024
@ItalyPaleAle ItalyPaleAle added the pinned Issue does not get stale label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pinned Issue does not get stale stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItalyPaleAle @berndverst